Skip to content

Implement transient traits and identities #4278

Closed
14 of 14 issues completed
Closed

Description

@khvn26

Goal

To support additional use cases, such as evaluating identities in different contexts or managing anonymous identities, we aim to enable our SDK users to:

  1. Evaluate flags against identities without persisting them.
  2. Evaluate flags against identities while persisting only a subset of identity traits.

Solution Proposal

Make /api/v1/identities endpoints support optional boolean "transient" attributes both for the top-level identity object and a trait object.

Don't persist identities and traits marked as transient.

In SDKs, support transient: bool and transientTraits: list[str] optional keywords for the getIdentityFlags interface.

Related issues and discussions

Customer requests and use case discussions:

API tasks:

SDK tasks:

Activity

  1. added
    apiIssue related to the REST API
    sdkIssues related to the SDKs
    edge-apiRelated to edge.api.flagsmith.com
    on Jul 3, 2024
  2. novakzaballa commented on Jul 4, 2024

    @novakzaballa
    Contributor

    @khvn26 I understand that we should implement transient traits because it is a quick and cost-effective way to cover some of the use cases related to contexts. While it could also help with anonymous identities or other use cases, we should keep the scope restricted to transient traits since that is the reason we decided to move ahead with its implementation.
    Also, as mentioned in this Notion regarding Anonymous identities https://www.notion.so/flagsmith/Anonymous-identities-904943c595474ae3b792f935109fb6f6 I think that for most we should persist annonymous identities or at least offer that option for most of the real use cases.

  3. novakzaballa commented on Jul 4, 2024

    @novakzaballa
    Contributor

    Regarding the implementation, I would rather suggest to add a boolean attribute to the trait model, so you can specify and persist whether it is transient or not. That would allow customers to design the behavior of flags, and would allow transient flags without changes to the SDKs. We could also allow SDKs to request a trait to be marked as transient, but that would be optional.

  4. khvn26 commented on Jul 4, 2024

    @khvn26
    MemberAuthor

    I would rather suggest to add a boolean attribute to the trait model, so you can specify and persist whether it is transient or no

    @novakzaballa I agree with this. However, not all SDKs expose the trait model; some, mainly the server-side ones, accept a simple string to value mapping instead. I suggest we use the transientTraits: list[str] parameter for those and add a transient boolean property to the Trait model for SDKs that support them in their public interfaces.

  5. novakzaballa commented on Jul 4, 2024

    @novakzaballa
    Contributor

    Agreed @khvn26

  6. khvn26 commented on Jul 24, 2024

    @khvn26
    MemberAuthor

    As discussed here and offline, we're choosing to leave out the additional parameter in favour of extending the trait_value parameter type. In addition to current TraitValue | null type, the parameter should accept a mapping/object:

    {
       transient: boolean
       value: TraitValue
    }
  7. self-assigned this
    on Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

apiIssue related to the REST APIedge-apiRelated to edge.api.flagsmith.comsdkIssues related to the SDKs

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions