Bump cyclonedx-core-java and json-schema-validtor libs - #6515
Conversation
Bumps cyclonedx-core-java to 12.2.0 and json-schema-validator to 2.0.3 (the latter was blocking the former). Addresses a variety of breaking changes in json-schema-validator, among them: * Renaming and relocation of classes * Changes in default error message content Additionally, moves the schema validation logic entirely into our own `CycloneDxValidator` instead of delegating to cyclonedx-core-java. The reason for this is that I noticed during testing that cyclonedx-core-java does not cache schemas after first use, so every validation call would reload schemas from disk, and recompile them, which is just wasted work. Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| Security | 1 critical |
🟢 Metrics 0 complexity · -2 duplication
Metric Results Complexity 0 Duplication -2
🟢 Coverage 86.17% diff coverage
Metric Results Coverage variation Report missing for ec3a6941 Diff coverage ✅ 86.17% diff coverage (70.00%) Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (ec3a694) Report Missing Report Missing Report Missing Head commit (263fd95) 42349 36740 86.76% Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#6515) 94 81 86.17% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
2 participants
Description
Bumps cyclonedx-core-java to 12.2.0 and json-schema-validator to 2.0.3 (the latter was blocking the former).
Addresses a variety of breaking changes in json-schema-validator, among them:
Additionally, moves the schema validation logic entirely into our own
CycloneDxValidatorinstead of delegating to cyclonedx-core-java. The reason for this is that I noticed during testing that cyclonedx-core-java does not cache schemas after first use, so every validation call would reload schemas from disk, and recompile them, which is just wasted work.Addressed Issue
N/A
Additional Details
Supersedes
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordinglyThis PR is a substantial change (per the ADR criteria), and I have added an ADR underdocs/adr/