Repository navigation
fix(injector): preserve negated may matches - #857
Merged
Merged
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 34c800c | Docs | Datadog PR Page | Give us feedback! |
eliottness
force-pushed
the
eliottness/fix-negated-may-filter
branch
from
July 24, 2026 10:25
9a0e645 to
34c800c
Compare
eliottness
marked this pull request as ready for review
July 24, 2026 11:20
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
+ Coverage 65.72% 75.11% +9.39%
==========================================
Files 113 118 +5
Lines 7926 7036 -890
==========================================
+ Hits 5209 5285 +76
+ Misses 2192 1556 -636
+ Partials 525 195 -330
🚀 New features to boost your workflow:
|
RomainMuller
approved these changes
Jul 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
kakkoyun
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MatchType.Notconservative for existential may-match resultscrypto/sha1.Sumversus(*digest).SumRoot cause
may.Matchmeans that at least one node may match. Negating that result asNeverMatchwas unsound: a package can contain both a matching receiver method and another function that satisfies the complete join point. The early package filter therefore discarded the aspect before node-level matching could distinguish them.Testing
go test -count=1 -run 'Test/function-body-negated-receiver$' -v ./internal/injector\n-GOPROXY=https://proxy.golang.org,direct go test -race -shuffle=on -count=1 ./internal/injector/...\n-golangci-lint run ./internal/injector/aspect/may/... ./internal/injector/aspect/join/... ./internal/injector/parse/...\n-GOPROXY=https://proxy.golang.org,direct go build ./...