Skip to content

Exclude generated directories for formatting - #1568

Merged
bulldozer-bot[bot] merged 3 commits into
developfrom
cr/include-src-dir
Feb 11, 2026
Merged

bulldozer-bot[bot] merged 3 commits into
developfrom
cr/include-src-dir

Conversation

@crogoz

@crogoz crogoz commented Feb 10, 2026 •

Copy link
Copy Markdown
Contributor

Before this PR

FLUP for #1531
Some source directories might have build in the directory structure; this regex would ignore these files.

After this PR

Exclude generated directories - same logic as in error-prone here. Internal thread here.

==COMMIT_MSG==
Exclude generated directories
==COMMIT_MSG==

Possible downsides?

@changelog-app

changelog-app Bot commented Feb 10, 2026 •

Copy link
Copy Markdown

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Exclude generated directories from formatting

Check the box to generate changelog(s)

  • Generate changelog entry

@crogoz crogoz changed the title reinclude src/ dirs Reinclude src/**/build dirs for formatting Feb 10, 2026
@changelog-app

changelog-app Bot commented Feb 10, 2026 •

Copy link
Copy Markdown

✅ Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

🔄 Changelog entries were re-generated at Wed, 11 Feb 2026 09:34:50 UTC!


📋Changelog Preview

🐛 Fixes

  • Exclude generated directories from formatting (#1568)

@crogoz crogoz changed the title Reinclude src/**/build dirs for formatting Exclude generated directories for formatting Feb 11, 2026

@kelvinou01 kelvinou01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than small nit

Comment on lines +54 to +58
// Exclude generated source directories
java.targetExclude("**/build/generated*/**");
java.targetExclude("**/src/generated*/**");
java.targetExclude("**/generated_*src/**");
java.targetExclude("**/generated_*Src/**");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be useful to explain here that some projects have build as a folder name, so we can't blanket ignore it

@crogoz
crogoz requested a review from kelvinou01 February 11, 2026 11:41
@bulldozer-bot
bulldozer-bot Bot merged commit b5d15de into develop Feb 11, 2026
7 checks passed
@bulldozer-bot
bulldozer-bot Bot deleted the cr/include-src-dir branch February 11, 2026 14:56
@autorelease3

autorelease3 Bot commented Feb 11, 2026

Copy link
Copy Markdown

Released 2.87.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants