Repository navigation
Chore better zizmor - #573
Merged
Merged
Conversation
Set up linting for gh actions yaml and wire up this linter to be able to fail PRs. Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Husky was warning that this line was deprecated and would start failing in a future release. Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
kzantow
approved these changes
Jan 16, 2026
kzantow
reviewed
Jan 16, 2026
| run: ${{ steps.grype.outputs.cmd }} version | egrep "^Version:.*0.54.0$" | ||
| env: | ||
| GRYPE_CMD: ${{ steps.grype.outputs.cmd }} | ||
| run: $GRYPE_CMD version | egrep "^Version:.*0.54.0$" |
Contributor
There was a problem hiding this comment.
should these be quoted? "$GRYPE_CMD"?
Contributor
Author
There was a problem hiding this comment.
is the grype command a single string? Like, is grype command ever 'grype -c /path/to/config --whatever'? if so quoting will break it IIUC.
Contributor
There was a problem hiding this comment.
If it's on windows, it could have spaces, it's always safer to quote, I think... it probably doesn't have spaces, but just to be on the safe side, it could
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without the husky precommit change we see like this: