Skip to content

Chore better zizmor - #573

Merged
willmurphyscode merged 4 commits into
mainfrom
chore-better-zizmor
Jan 16, 2026
Merged

willmurphyscode merged 4 commits into
mainfrom
chore-better-zizmor

Conversation

@willmurphyscode

@willmurphyscode willmurphyscode commented Jan 16, 2026 •

Copy link
Copy Markdown
Contributor

without the husky precommit change we see like this:

❯ git commit -s -m temp
husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

Set up linting for gh actions yaml and wire up this linter to be able to fail
PRs.

Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Husky was warning that this line was deprecated and would start failing in a
future release.

Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
@willmurphyscode willmurphyscode added the changelog-ignore do not add a entry for this when generating the changelog label Jan 16, 2026
Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>
Comment thread .github/workflows/test.yml Outdated
run: ${{ steps.grype.outputs.cmd }} version | egrep "^Version:.*0.54.0$"
env:
GRYPE_CMD: ${{ steps.grype.outputs.cmd }}
run: $GRYPE_CMD version | egrep "^Version:.*0.54.0$"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these be quoted? "$GRYPE_CMD"?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the grype command a single string? Like, is grype command ever 'grype -c /path/to/config --whatever'? if so quoting will break it IIUC.

@kzantow kzantow Jan 16, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's on windows, it could have spaces, it's always safer to quote, I think... it probably doesn't have spaces, but just to be on the safe side, it could

Signed-off-by: Will Murphy <willmurphyscode@users.noreply.github.com>

@kzantow kzantow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@willmurphyscode
willmurphyscode merged commit 6ac601c into main Jan 16, 2026
32 checks passed
@willmurphyscode
willmurphyscode deleted the chore-better-zizmor branch January 16, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-ignore do not add a entry for this when generating the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants