Skip to content

fix: upgrade to terser@5.31.0 to fix minfy with negated in statements - #1194

Closed
byCedric wants to merge 1 commit into
vercel:mainfrom
byCedric:fix/issue-1193
Closed

byCedric wants to merge 1 commit into
vercel:mainfrom
byCedric:fix/issue-1193

Conversation

@byCedric

@byCedric byCedric commented Jun 4, 2024

Copy link
Copy Markdown

Fixes #1193

@byCedric
byCedric requested review from Timer and styfle as code owners June 4, 2024 15:14

@styfle styfle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byCedric

byCedric commented Jun 6, 2024 •

Copy link
Copy Markdown
Author

These are interesting failures, I'm not sure why Node 20 on Ubuntu causes that error, while Node 20 on Windows seems fine.

The MacOS errors are just node-gyp (install) related issues, likely due to the GHA runner missing some low-level dependency. It's also erroring on node-canvas which isn't touched in this PR.

Edit: yeah, the macos failures are definitely related to missing system dependencies:

image

@byCedric

byCedric commented Jun 6, 2024

Copy link
Copy Markdown
Author

Also interesting here is that the last run on workflow (4 months ago) did not succeed for Node 20 on Ubuntu (this run). Unfortunately, the logs have been wiped already, but that might be a pointer to this failure too.

I'm also guessing the macos-latest runner has been changed within 4 months, causing the CI failures.

@styfle

styfle commented Jun 7, 2024 •

Copy link
Copy Markdown
Member

I see what you mean. I'll run CI against main to see how it compares:

@byCedric

byCedric commented Jun 8, 2024 •

Copy link
Copy Markdown
Author

Glad you could repro this on main (as in, not caused by this PR) 😄

Anything I can do to help?

@styfle

styfle commented Jun 10, 2024

Copy link
Copy Markdown
Member

I think we need to fix main before merging this to confirm it works as expected

@theoludwig

Copy link
Copy Markdown
Contributor

I think we need to fix main before merging this to confirm it works as expected

What was the problem with CI (the logs disappeared)? Should probably run CI again, with all the depdencies updated to their latest version, to see the status of the project.

@styfle

styfle commented Sep 10, 2024

Copy link
Copy Markdown
Member

@theoludwig Feel free to create a new PR to fix it

@theoludwig

Copy link
Copy Markdown
Contributor

@theoludwig Feel free to create a new PR to fix it

Alright. 😄 #1213

Tests are working locally, but about CI, I don't know, need an approval to run it. Hopefully, it fixes the issue, and allow to update terser and webpack to latest version to get latest fixes like this one with negated in statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated Terser causes a syntax issue when minify-ing code

3 participants