Repository navigation
Wait for resources to become available between actor pool stages - #2357
Merged
Merged
Conversation
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 0f04448 |
praateekmahajan
approved these changes
Sep 3, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ray actor pool executor goes stage by stage kills all actors and the end of the stage and restarts new set of actors for the next stage.
The executor gauges how many actors it can start by looking at
cluster.available_resources.But given that ray.kill is async and it may take time for the available resources to update, the default sleep of 0.2s may not be enough for all machines to free up existing processes.
This may lead to fewer resources being spun up for future stages or no resources available at all leading to errors.
The new proposed solution adds the following:
intervalsecondstimeouts the stage starts with whatever is available.Here's the new process:
a. If a stage now has enough resources to get these actors, start the stage.
b. If a stage doesn't have enough resources to get these actors, sleep for
intervalseconds and recheck.c. If a stage doesn't have enough resources to get these actors even after timeout raise an error
Usage
# Add snippet demonstrating usageChecklist